Provide mechanism for autopopulating node.js process.env

[jasnell]

Autopopulates the process.env from bindings in local dev. A similar PR will be needed internally to enable it there as it won't be automatic.

See caveats: #3311 (comment)

[vicb]

@irvinebroque can we discuss this?

I oppose this change of it exposed secrets to the world via process.env

[jasnell]

I oppose this change of it exposed secrets to the world via process.ENV

To be clear... the change puts any TEXT binding on process.env. We have no way of knowing if a a TEXT binding contains something that is considered a secret or not. If tooling insists on adding secrets to the worker configuration using a TEXT binding then this would mean we just cannot populate process.env automatically at all right now because we have zero ability to differentiate if the value of the TEXT binding is secret or not.

[vicb]

@jasnell I think the following info needs to be added to the PR description (I can not edit it):

This PR

• is gated by the nodejs_compat_populate_process_env compatibility flag
• depends on Use TEXT bindings for plain text values in Miniflare workers-sdk#7738
• publishes string environment variables and secrets to process.env

# wrangler.toml
[vars]
PUBLISHED = "foo"
PUBLISHED_INT = "1"
PUBLISHED_BOOL = "true"
PUBLISHED_JSON = "{key: value}"
PUBLISHED_ARRAY = "[1]"

NOT_PUBLISHED_INT = 120
NOT_PUBLISHED_BOOL = true
NOT_PUBLISHED_JSON = {key = value}
NOT_PUBLISHED_ARRAY = [1]

# .dev.vars
PUBLISHED_SECRET = "secret"

Once the description has been added, it would be nice to create an issue on https://github.com/cloudflare/cloudflare-docs to ask this to be documented when merged

[kentonv]

Sorry I really insist on this: All bindings which render to a plain string must be treated equivalently. We cannot have the behavior change based on the way the value was originally specified in config, because this is changing the abstraction in a way that has already been seen to break multiple tools and adds new constraints to our implementation going forward. The abstraction is that env contains JavaScript values; whether they were transmitted as simple text, JSON, v8 serilaization, etc. is not revealed to the application.

[jasnell]

Moved back to draft due to continued backend discussion on how the implementation intersects with non-nodejs-compat related aspects of the runtime.