Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ffi: make quiche_conn_path_event_next return mut pointer (fix #1905) #1908

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ffi: make quiche_conn_path_event_next return mut pointer (fix #1905) #1908

wants to merge 1 commit into from

Conversation

ichordev
Copy link

@ichordev ichordev commented Jan 14, 2025 •
edited
Loading

Changes quiche_conn_path_event_next so that it returns a mutable pointer on both the C and Rust side. This fixes issue #1905.
Also added const to the quiche_path_event* parameters in the following functions from quiche.h in order to match their mutability in ffi.rs:

  • quiche_path_event_type
  • quiche_path_event_new
  • quiche_path_event_validated
  • quiche_path_event_failed_validation
  • quiche_path_event_closed
  • quiche_path_event_reused_source_connection_id
  • quiche_path_event_peer_migrated

@ichordev ichordev requested a review from a team as a code owner January 14, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ichordev