Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffi: const quiche_path_event* expected to be passed to quiche_path_event* parameters #1905

Closed
ichordev opened this issue Jan 14, 2025 · 0 comments

Comments

@ichordev
Copy link
Contributor

The only way to get a quiche_path_event is from the return value of quiche_conn_path_event_next. It returns a const quiche_path_event*. However, all the functions that operate on a quiche_path_event take a mutable quiche_path_event* in quiche.h, meaning you have to cast away const on the pointer to use it anywhere or else you get an error. This seems to be a mistake, because in ffi.rs none of those function parameters are mut (with the exception of quiche_path_event_free). Perhaps quiche_conn_path_event_next should just return a mutable pointer?

@ichordev ichordev changed the title FFI: const quiche_path_event* expected to be passed to quiche_path_event* parameters ffi: const quiche_path_event* expected to be passed to quiche_path_event* parameters Jan 14, 2025
@ghedo ghedo closed this as completed in 028f8ac Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant