Skip to content
This repository has been archived by the owner on Feb 19, 2025. It is now read-only.

Rename SrcIf to InIf and DstIf to OutIf #49

Merged
merged 1 commit into from
Jan 31, 2020
Merged

Rename SrcIf to InIf and DstIf to OutIf #49

merged 1 commit into from
Jan 31, 2020

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Jan 2, 2020

Closes #28

@lspgn
Copy link
Contributor

lspgn commented Jan 6, 2020

Looks like Travis was having issues fetching libraries.
Was the proto regenerated using protoc?

Thank you

@simPod
Copy link
Contributor Author

simPod commented Jan 6, 2020

Just regenerated through protoc

@lspgn
Copy link
Contributor

lspgn commented Jan 30, 2020

did you run PROTOCPATH=$HOME/go/bin/ make proto? Getting slightly different protobuf generated file.

@simPod
Copy link
Contributor Author

simPod commented Jan 31, 2020

@lspgn I run this now PROTOCPATH=/usr/local/bin make proto There were some changes, check now 🤔

@lspgn lspgn merged commit 699477c into cloudflare:master Jan 31, 2020
@simPod simPod deleted the rename-if-fields branch February 1, 2020 15:40
tgragnato pushed a commit to tgragnato/goflow that referenced this pull request Aug 14, 2024
* Refactor template as module
* Abstraction to allow custom template storage (eg: file, redis, http...)
* Works similarly to Transport and Format
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DstIf/SrcIf vs InIf/OutIf naming
2 participants