Skip to content
This repository has been archived by the owner on Feb 19, 2025. It is now read-only.

DstIf/SrcIf vs InIf/OutIf naming #28

Closed
simPod opened this issue Jun 2, 2019 · 5 comments · Fixed by #49
Closed

DstIf/SrcIf vs InIf/OutIf naming #28

simPod opened this issue Jun 2, 2019 · 5 comments · Fixed by #49

Comments

@simPod
Copy link
Contributor

simPod commented Jun 2, 2019

Hi, what is the reason for naming fields as DstIf and SrcIf? So far I have seen InIf and OutIf naming for the same thing. Thanks!

@lspgn
Copy link
Contributor

lspgn commented Jun 4, 2019

Mostly consistency with other fields (source IP, source port...). But no other reasons.
Is it causing conflicts?

@simPod
Copy link
Contributor Author

simPod commented Jun 5, 2019

@lspgn Thanks for response! No conflicts. But it's usually called input and output so I wonder that it might be confusing. Also, src and dst fields represent something else in flow. Those are really info about packet's source and destination but inif and outif represent interfaces on the device where the flow is recorded. WDYT?

@AntoineThebaud
Copy link

AntoineThebaud commented Oct 9, 2019

Hello, I agree on this one, even more considering the name of the corresponding fields for NetFlow

SrcIf | ... | input  | ... | INPUT_SNMP (10)  | ...
DstIf | ... | output | ... | OUTPUT_SNMP (14) | ...

@lspgn
Copy link
Contributor

lspgn commented Dec 23, 2019

Coming back to this a bit late.
This makes sense, I will change the protobuf field names (or feel free to PR).
Though I was not very eager to change the data structure since some people may use this as a library (but as long as I keep the IDs the same it is fine).

@simPod
Copy link
Contributor Author

simPod commented Dec 24, 2019

👍 I'll look into it. Releasing with proper version bump should then be IMO k.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants