Update CloudEvents SDK to support most recent spec change to extensions #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berndtj
reviewed
Sep 13, 2018
There was a problem hiding this comment.
Can you squash your commits and provide a clean commit message? This does seem like quite a big change and I'd like to understand what is going on without having to read the spec (both before and after).
Also, please comment the code a bit more. It's not straightforward, what's being done, and we want an 3rd party to be able to understand. I'll give a more thorough review once there's more commentary.
Great job on the tests.
http.go
Outdated
| if ok := ptr.Implements(eventType); ok { | ||
| e := reflect.New(t) | ||
| version := e.MethodByName("CloudEventVersion").Call([]reflect.Value{})[0].Interface().(string) | ||
| println(version) |
http.go
Outdated
| e := &v01.Event{} | ||
| err := e.FromHTTPRequest(req) | ||
| return e, err | ||
| eventType := reflect.TypeOf((*Event)(nil)).Elem() |
There was a problem hiding this comment.
This needs comments. I have no idea why we are doing all this reflection
v01/event.go
Outdated
| // Data is an optional property | ||
| // https://github.com/cloudevents/spec/blob/v0.1/spec.md#data-1 | ||
| Data interface{} `json:"data,omitempty"` | ||
| cloudEventsVersion string |
…erializers/deserializers
8e48d25 to
78075ad
Compare
kars7e
approved these changes
Oct 17, 2018
n3wscott
pushed a commit
that referenced
this pull request
Oct 1, 2021
* Introduce OpenTelemetry observability service (#2) Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com> Co-authored-by: Georg Pirklbauer <georg.pirklbauer@dynatrace.com> Signed-off-by: Joao Grassi <joao.grassi@dynatrace.com> * Upgrade OTel package to 1.0.0 Signed-off-by: Joao Grassi <joao.grassi@dynatrace.com> Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com> Co-authored-by: Georg Pirklbauer <georg.pirklbauer@dynatrace.com>
embano1
pushed a commit
that referenced
this pull request
May 1, 2024
* allow context to override the default timeout Signed-off-by: Noah Kreiger <noahkreiger@gmail.com>
This was referenced Jul 2, 2024
Merged
JamesBLewis
pushed a commit
to JamesBLewis/sdk-go
that referenced
this pull request
Jul 5, 2024
* allow context to override the default timeout Signed-off-by: Noah Kreiger <noahkreiger@gmail.com> Signed-off-by: James Lewis <james.lewis2@anz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel like I may have over engineered this one. Any input is welcome, especially with regards to the end user experience.