Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WithHost Option #1070

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Conversation

jaxtonw
Copy link
Contributor

@jaxtonw jaxtonw commented Jul 2, 2024

Implements suggested solution #2 from Issue #1069.

Adds a new WithHost option for HTTP Protocols to enable the ability to set the HTTP Host header manually.

@jaxtonw jaxtonw requested a review from a team as a code owner July 2, 2024 03:11
@jaxtonw jaxtonw force-pushed the 1069-set-host-header branch 2 times, most recently from 1517c03 to 39444c5 Compare July 2, 2024 03:28
Signed-off-by: Jaxton Winder <jaxton.winder@gmail.com>

Improve error message for nil protocol

Signed-off-by: Jaxton Winder <jaxton.winder@gmail.com>

Add unit test for WithHost

Signed-off-by: Jaxton Winder <jaxton.winder@gmail.com>
@embano1 embano1 merged commit 8efefb0 into cloudevents:main Jul 4, 2024
9 checks passed
@embano1
Copy link
Member

embano1 commented Jul 4, 2024

Thank you!

@jaxtonw
Copy link
Contributor Author

jaxtonw commented Jul 7, 2024

@embano1 happy to help! Roughly when can we expect the next release that this change will be included in?

@embano1
Copy link
Member

embano1 commented Jul 8, 2024

@embano1 happy to help! Roughly when can we expect the next release that this change will be included in?

We definitely need to cut a new release with all the recent changes. There's another PR for PubSub which I want to get in as well (need to review) but I'm currently on vacation.

cc/ @duglin

@jaxtonw
Copy link
Contributor Author

jaxtonw commented Jan 16, 2025

@embano1 @duglin Hi y'all! We got this merged in back in July, but there still has yet to be a new release for the sdk-go module, which had it's last release in March 2024. Do we have any ETA for getting together our next update? Anything I could do to help?

@embano1
Copy link
Member

embano1 commented Jan 19, 2025

@jaxtonw that is a very fair comment. We definitely should cut a new release, it's been 111 commits since our last release. IIRC, we had some breaking changes, very minimal IIRC, and therefore I'd like to discuss the versioning strategy here. We likely won't do a 3.x and therefore have to be careful because users would not consider a 2.16.0 breaking. cc/ @duglin

@embano1
Copy link
Member

embano1 commented Jan 19, 2025

The commits can be grouped into the following categories based on their descriptions and purposes:

1. Dependency Updates

These commits are focused on updating dependencies, including libraries, GitHub Actions, or other tools:

  • GitHub Actions Updates:

    • a1fb808, b6d3640: Bump golangci/golangci-lint-action from 6.1.1 to 6.2.0.
    • cfad92d, 8d7f176: Bump actions/setup-go from 5.1.0 to 5.2.0.
    • 24f83eb, afa9cb8: Bump actions/setup-go from 5.0.2 to 5.1.0.
    • 414cc32, b515698: Bump actions/checkout from 4.2.1 to 4.2.2.
    • 6bcc075, b89572d: Bump actions/checkout from 4.2.0 to 4.2.1.
    • 78d3fba, e464c70: Bump golangci/golangci-lint-action from 6.1.0 to 6.1.1.
    • 421eca9, 89e21c3: Bump actions/checkout from 4.1.7 to 4.2.0.
    • 1ed9471, d277ea9: Bump golangci/golangci-lint-action from 5 to 6.
    • 9c00184, 169a596: Bump golangci/golangci-lint-action from 4 to 5.
  • Go Modules Updates:

    • 7e6729c, df16e77: Bump github.com/stretchr/testify to v1.10.0.
    • 70fb951, d9f14e3: Bump github.com/nats-io/nats-streaming-server.
    • 2db66e0, 44540fb: Bump observability/opencensus go_modules.
    • 55116c1: Bump github.com/nats-io/nats-streaming-server.
    • d3996c9, 20bfd0a: Bump observability/opencensus go_modules.
    • ef734d0, f4d014f: Bump binding/format/protobuf go_modules.
    • 0a3095d, ba94827: Bump test/sql go_modules.
  • Bundler Updates:

    • aabcd2b, 71e0640: Bump nokogiri in Bundler.

2. New Features and Enhancements

These commits introduce new features or improvements:

  • c73615f: Add v3 version of NATS Jetstream protocol with integration tests and samples.
  • eb93b65: Add NATS Ack/Nak to NATS Jetstream V3 Finish.
  • ab040db: Add flexibility in subject matching for NATS Jetstream.
  • 7fef294: Add eventHandler option for Confluent Kafka producer.
  • 80fd2cf: Initial implementation of user-defined functions with TCK tests.
  • c68ed0e: Support content types following structured syntax suffixes.

3. Bug Fixes

These commits address bugs or issues:

  • e029ccf: Fix the race condition of MQTT.
  • 2494906: Fix token-permission issue.
  • 9ac82a9: Fix pinned dependencies.
  • 72dc26d: Fix pubsub to return error if acked is enabled.
  • b826898: Fix pubsub ack to rely on protocol.IsAck.
  • e864ebd: Fix invalid CE prefix in Confluent binding.
  • 426d8de: Fix parser for integer literals.
  • 3e20125: Fix LIKE expression with invalid string literals.
  • 4cafcc3: Fix support for multiple AMQP data fields.

4. Documentation Improvements

These commits improve or update documentation:

  • b94c458, 378a031, 2e9d548: Improvements to StartReceiver function documentation.
  • b877ab4, 22596a9: Update test function names and copyright.

5. Performance Improvements

These commits improve the performance of specific components:

  • 17059e8: Improve performance of LIKE matching.
  • 19fd3f2: Add check for empty pattern.

6. Tests and Benchmarks

These commits involve tests and benchmarking:

  • e8fccd2, 782e776: Add tests for user-defined functions.
  • 8e8d5dd: Add benchmarks for CESQL.

7. Code Cleanup

These commits involve code refactoring, cleanup, or minor updates:

  • 1b20dee: Fix golangci-lint errors.
  • 855f31c: Update workflows and dependencies to Go 1.22.
  • 69917e3: Cleanup license headers.
  • f811b66: Move runtime tests to a dedicated directory.

8. Other Updates

  • f97061a: Allow Context to Configure Default Timeout.
  • 7e6729c, df16e77: Update Go test dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants