tests: fully switch to deps.edn #20
Comments
|
Our tests are using an old version of ring/ring-jetty-adapter which brings in jetty v7 which was retired in 2014. This tech is used to prop up a server for tests to hit. There might be some value in updating it, but I'll consider this out of scope for this issue. |
|
Agreed |
lread
added a commit
to lread/clj-http-lite
that referenced
this issue
Aug 12, 2022
No longer using lein at all. Bumped all deps to current releases except for ring-jetty-adapter. It is used for testing only, and bumping will require code changes. Can address as a separate issue later, if we like. Turfed bb test:clj task. I did not want to wrap clojure cli test running with bb as part of this work Removed special instructions in README about skipping integration tests, they run very fast, so not generally worth skipping. Dropped testing of Clojure 1.7, Clojure tools cli min version seems to be 1.8, and we planned to to this anyway as part of clj-commons#21. Added new bb tasks to replace lein's versions - clean - deps - brings down all deps Closes clj-commons#20
borkdude
pushed a commit
that referenced
this issue
Aug 13, 2022
* tests: move fully to deps.edn No longer using lein at all. Bumped all deps to current releases except for ring-jetty-adapter. It is used for testing only, and bumping will require code changes. Can address as a separate issue later, if we like. Turfed bb test:clj task. I did not want to wrap clojure cli test running with bb as part of this work Removed special instructions in README about skipping integration tests, they run very fast, so not generally worth skipping. Dropped testing of Clojure 1.7, Clojure tools cli min version seems to be 1.8, and we planned to to this anyway as part of #21. Added new bb tasks to replace lein's versions - clean - deps - brings down all deps Closes #20 * bump ci bb to latest, cleanup unused requires
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In support of #18 (comment)
There is some minimal support for running tests via Clojure cli from bb tasks, but because not all test namespaces do not end in
-testonly a subset of tests are being run. Will adjust runner.Will also freshen outdated deps.
And delete
project.cljto avoid any confusion.The text was updated successfully, but these errors were encountered: