Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow registering translations in the defaultConfig #15903

Merged
merged 4 commits into from
Feb 23, 2024

Conversation

filipsobol
Copy link
Member

Suggested merge commit message (convention)

Fix (core): Use translations from the defaultConfig if they were not provided in the create method. Closes #15902.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@filipsobol filipsobol requested a review from arkflpc February 22, 2024 10:49
Copy link
Contributor

@illia-stv illia-stv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@filipsobol filipsobol requested a review from arkflpc February 22, 2024 13:32
@filipsobol filipsobol merged commit 39c3fa7 into master Feb 23, 2024
7 checks passed
@filipsobol filipsobol deleted the ck/15902-allow-translations-in-defaultConfig branch February 23, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The translations object is ignored when used in defaultConfig
4 participants