Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The translations object is ignored when used in defaultConfig #15902

Closed
filipsobol opened this issue Feb 22, 2024 · 0 comments · Fixed by #15903
Closed

The translations object is ignored when used in defaultConfig #15902

filipsobol opened this issue Feb 22, 2024 · 0 comments · Fixed by #15903
Assignees
Labels
squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@filipsobol
Copy link
Member

The newly added translations configuration option only works when used in the second parameter of the Editor.create() method. However, it should also be possible to define it in the defaultConfig property of the Editor class:

export default class Editor extends ClassicEditor {
  public static override builtinPlugins = [ /* ... */ ];

  public static override defaultConfig = {
    /* ... */
    translations,
  };
}
@filipsobol filipsobol added type:bug This issue reports a buggy (incorrect) behavior. squad:core Issue to be handled by the Core team. labels Feb 22, 2024
@filipsobol filipsobol self-assigned this Feb 22, 2024
filipsobol added a commit that referenced this issue Feb 23, 2024
Fix (core): Use `translations` from the `defaultConfig` if they were not provided in the `create` method. Closes #15902.
@CKEditorBot CKEditorBot added this to the iteration 72 milestone Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants