Fix (engine): detecting restricted objects in firefox #14706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleq
requested changes
Aug 2, 2023
packages/ckeditor5-engine/src/view/observer/selectionobserver.ts
Outdated
Show resolved
Hide resolved
packages/ckeditor5-engine/src/view/observer/selectionobserver.ts
Outdated
Show resolved
Hide resolved
packages/ckeditor5-engine/src/view/observer/selectionobserver.ts
Outdated
Show resolved
Hide resolved
packages/ckeditor5-engine/tests/view/observer/selectionobserver.js
Outdated
Show resolved
Hide resolved
packages/ckeditor5-engine/tests/view/observer/selectionobserver.js
Outdated
Show resolved
Hide resolved
oleq
approved these changes
Aug 2, 2023
niegowski
reviewed
Aug 2, 2023
packages/ckeditor5-engine/src/view/observer/selectionobserver.ts
Outdated
Show resolved
Hide resolved
niegowski
requested changes
Aug 3, 2023
niegowski
reviewed
Aug 4, 2023
niegowski
reviewed
Aug 21, 2023
niegowski
requested changes
Aug 25, 2023
packages/ckeditor5-engine/tests/view/observer/selectionobserver.js
Outdated
Show resolved
Hide resolved
packages/ckeditor5-engine/tests/view/observer/selectionobserver.js
Outdated
Show resolved
Hide resolved
niegowski
reviewed
Aug 30, 2023
packages/ckeditor5-engine/tests/view/observer/selectionobserver.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix (engine): Don't throw an error when clicking on baloon with input on Firefox. Closes #9635.
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.