-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Firefox] Error when clicking on label elements inside editor #9635
Comments
To me it looks like some sort of weird issue in Firefox. From a quick research, it looks like it is connected with selection and inputs. As far as I can tell, the error does not occur when you click on texts in the version item (for example, author name). The issue happens when you click on place next to an input. I think that Firefox messes up with selection then. What happens is, Firefox set selection in a way that the selection is in the input but when you try to get a range from the selection and then start and end container of the range, Firefox returns "Restricted" object, which throws when any of its property is accessed: When you check selection anchor and focus, correct DOM element is returned, but in line 512 "Restricted" object is returned. AFAICS, this error does not have an impact on editor, i.e. editor works. Am I right? What we could do is:
|
I just found another way to reproduce this, but it doesn't involve interacting with CKEditor at all. All you need is a CKEditor instance on the page. Ignore it. Leave it there. Focus on the rest of the form. Click randomly on any other In spite of the error, the editor works fine. This error doesn't break anything, as far as I can see. |
Any update on this? |
@AhmedEzzat12 Does this error in any way impact how your editor works? |
@scofalik It freezes the whole UI for a few seconds and then it resumes, the problem is that it doesn't happen when interacting with the editor itself only but having at least one instance of it on the page is enough for the error to occur. |
Subscribe +1 |
…n-label-elements-inside-editor Fix (engine): Don't throw an error when clicking on a balloon with input on Firefox. Closes #9635.
Same here, we experience freezing after this error |
📝 Provide detailed reproduction steps (if any)
There are multiple ways to reproduce this ( see screencasts below ), example steps:
Text alternative
✔️ Expected result
Nothing Happens
❌ Actual result
Screencasts
0_firefox1.mp4
0_firefox3.mp4
0_firefox2.mp4
📃 Other details
24.0.0
If you'd like to see this fixed sooner, add a 👍 reaction to this post.
The text was updated successfully, but these errors were encountered: