Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock dialog (modal) page scroll on <html> instead of <body> to make it bulletproof #17298

Closed
oleq opened this issue Oct 22, 2024 · 0 comments · Fixed by #17299
Closed

Lock dialog (modal) page scroll on <html> instead of <body> to make it bulletproof #17298

oleq opened this issue Oct 22, 2024 · 0 comments · Fixed by #17299
Assignees
@oleq
Labels
package:ui
Milestone
iteration 79 (v43...

Comments

@oleq
Copy link
Member

oleq commented Oct 22, 2024

This is a follow-up of #17093.

I discovered that the fix introduced in #17247 does not work in the project's docs because body { height: 100vh } style that ensures <body> is never (vertically) scrollable. I propose moving the scroll lock from <body> to <HTML> to work around this issue.
@oleq oleq self-assigned this Oct 22, 2024
@oleq oleq mentioned this issue Oct 22, 2024
Merged
oleq added a commit that referenced this issue Oct 22, 2024
@oleq
Merge pull request #17299 from ckeditor/ck/17298
90a133f 
Internal (ui): Moved the document scroll lock for modal windows from `<body>` to `<html>` to make it bulletproof. Closes #17298.
@CKEditorBot CKEditorBot added this to the iteration 79 milestone Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:ui
Projects
None yet
Milestone
iteration 79 (v43.3.0)
Development

Successfully merging a pull request may close this issue.

Moved the document scroll lock for modal windows from <body> to <html> ckeditor/ckeditor5
2 participants
@oleq @CKEditorBot