Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable page scroll when modal is open #17093

Closed
scofalik opened this issue Sep 13, 2024 · 0 comments · Fixed by #17247
Closed

Disable page scroll when modal is open #17093

scofalik opened this issue Sep 13, 2024 · 0 comments · Fixed by #17247
Assignees
@oleq
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:ui squad:collaboration Issue to be handled by the Collaboration team. type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 79 (v43...

Comments

@scofalik
Copy link
Contributor

📝 Provide a description of the improvement

When dialog is opened in the model mode, it is still possible to scroll the page "behind it". I think this is a bad UX, and it may lead to an unintended scrolling of the page, especially when there are dialogs that also has scrolls.

We should either disable the scroll or remove it. This unfortunately leads to the page "jumping", so if possible, I think that the best would be to disable the scroll if it is visible. If that's not possible we can discuss if it's worse to make the website jump or to allow scrolling in background.
@scofalik scofalik added type:improvement This issue reports a possible enhancement of an existing feature. package:ui domain:ui/ux This issue reports a problem related to UI or UX. squad:collaboration Issue to be handled by the Collaboration team. labels Sep 13, 2024
@oleq oleq mentioned this issue Oct 9, 2024
Merged
@oleq oleq self-assigned this Oct 9, 2024
oleq added a commit that referenced this issue Oct 21, 2024
@oleq
Merge pull request #17247 from ckeditor/ck/17093
926400f 
Fix (ui): Made the page unscrollable while the modal is visible. Closes #17093.
@CKEditorBot CKEditorBot added this to the iteration 79 milestone Oct 21, 2024
@CKEditorBot CKEditorBot mentioned this issue Oct 22, 2024
Open
@oleq oleq mentioned this issue Oct 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:ui squad:collaboration Issue to be handled by the Collaboration team. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 79 (v43.3.0)
Development

Successfully merging a pull request may close this issue.

Made the page unscrollable while the modal is visible ckeditor/ckeditor5
3 participants
@oleq @scofalik @CKEditorBot