Fixed bug with parsing border colors #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlewand
suggested changes
Jan 8, 2018
core/tools.js
Outdated
| @@ -1877,7 +1877,9 @@ | |||
| */ | |||
| border: function( value ) { | |||
| var ret = {}, | |||
| input = value.split( /\s+/ ); | |||
| // remove every white space after comma from color eg. rbg(10, 20, 30, .75) | |||
There was a problem hiding this comment.
Comment line should start with an uppercased letter and end with a dot.
I suggest going with:
// Remove every white space after comma from color eg. 'rbg(10, 20, 30, .75)'.
tests/core/tools/style.js
Outdated
| }, | ||
|
|
||
| 'test style.parse.border with color white spaces': function() { | ||
| objectAssert.areEqual( { style: 'solid', color: 'rgba(10,20,30,.75)', width: '1px' }, CKEDITOR.tools.style.parse.border( '1px solid rgba(10, 20, 30, .75)' ) ); |
There was a problem hiding this comment.
I'd rather like to have original color syntax, in a sense that spaces are not being removed if possible.
Reason for this is that by doing so we reduce possibility of CKEditor changing existing value format.
There was a problem hiding this comment.
You can do achieve that in CKEDITOR.tools.style.parse.border easily by obtaining ret.color before forEach.
|
I have pushed a commit with the expected |
mlewand
approved these changes
Jan 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Bug fix
Does your PR contain necessary tests?
All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.
This PR contains
What changes did you make?
Added regex to remove whitespaces from color model syntax to CKEDITOR.tools.style.parse.border() function.
Closes #1356
#1356: Fixed: Border shorthand converter should allow on space in color.