Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Border shorthand converter doesn't allow spaces in the color value #1356

Closed
msamsel opened this issue Dec 18, 2017 · 0 comments
Closed

Border shorthand converter doesn't allow spaces in the color value #1356

msamsel opened this issue Dec 18, 2017 · 0 comments
Labels
changelog:api A changelog entry should be put in the API section of the changelog. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Milestone
4.9.0

Comments

@msamsel
Copy link
Contributor

msamsel commented Dec 18, 2017

Are you reporting a feature request or a bug?

Bug

Provide detailed reproduction steps (if any)

  1. Use CKEDITOR.tools.style.parse.border() to convert border like 1px solid rgba( 10, 20, 30, .75 )

Expected result

Border is correctly splitted

Actual result

Color value is not returned

Note:

Border string is separate with white character, so there is processed string like rgba( instead of rgba( 100, 200, 30, .75 )

https://github.com/ckeditor/ckeditor-dev/blob/79e7ebecf6cff290f3b66894bce1b0fd89d3a15e/core/tools.js#L1878-L1907

Other details

  • Browser: All
  • OS: All
  • CKEditor version: 4.8.0
  • Installed CKEditor plugins: All
@msamsel msamsel added status:confirmed An issue confirmed by the development team. type:bug A bug. labels Dec 18, 2017
@msamsel msamsel mentioned this issue Dec 19, 2017
Merged
2 tasks
@mlewand mlewand added target:minor Any docs related issue that can be merged into a master or major branch. changelog:api A changelog entry should be put in the API section of the changelog. labels Dec 29, 2017
@mlewand mlewand added this to the Backlog milestone Dec 29, 2017
@mlewand mlewand added the good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. label Dec 29, 2017
@jacekbogdanski jacekbogdanski mentioned this issue Jan 8, 2018
Merged
2 tasks
@mlewand mlewand changed the title Border shorthand converter doesn't allow on space in color Border shorthand converter doesn't allow spaces in the color value Jan 9, 2018
@mlewand mlewand modified the milestones: Backlog, 4.8.1 Jan 9, 2018
@mlewand mlewand modified the milestones: 4.8.1, 4.9.0 Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
changelog:api A changelog entry should be put in the API section of the changelog. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Projects
None yet
Milestone
4.9.0
Development

No branches or pull requests
2 participants
@mlewand @msamsel