wp-rest - Disable SOAP end-point (now defunct) #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@seamuslee001 You've definitely got a +1 from me removing obsolete code 👍 |
|
@seamuslee001 Could you also remove (or edit) the SOAP reference in |
|
looks good to me as well. merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is as per civicrm/civicrm-core#25317 and removes the SOAP options from the wp-rest options
Before
Soap can be accessed but will fail as core has removed support
After
Soap end points generated by wp plugin no longer exist
ping @christianwach @kcristiano @totten @demeritcowboy