Disable extern/soap.php. Remove implementation and tests.

[totten]

Overview

There are no longer any known consumers of this interface, and it is awkward to maintain.

cc @seamuslee001

Technical Details

I left some informational stubs. There are still some other repos that reference the class CRM_Utils_SoapServer (e.g. civicrm-wordpress.git, civismtp.git), and we don't to make class-files unloadable. The WordPress integration can probably be updated in tandem, but sites may still have civismtp enabled.

(Note: Leaving stub files also addresses the Joomla loop-hole for deletion.)

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

seems fine to me any thoughts @demeritcowboy @eileenmcnaughton @colemanw @MegaphoneJon

[eileenmcnaughton]

I'm +1 on this. I think throwing an exception is good & that looks like a good approach

[MegaphoneJon]

I've never really touched this, but love watching code get removed. Also I think this removes the dependency on the PHP SOAP extension?

[eileenmcnaughton]

test this please

[totten]

(@MegaphoneJon) Also I think this removes the dependency on the PHP SOAP extension?

From a core POV, yes. Separately, Civi extensions may use PHP SOAP for other reasons. A quick grep of universe suggests a few examples (com.iatspayments.civicrm, com.aghstrategies.tsys, com.groupwho.paperlesstrans). (But that's independent of extern/soap.php.)

[seamuslee001]

Flagging as Merge ready in case anyone has any further comments

[seamuslee001]

Probably been long enough am merging now