Streamline and enhance the plugin load procedure (rebased) #271
Conversation
…d::install) This is a rebased/cherry-picked version of 921af8e. However, it skips the changes in`wp-cli/civicrm.php`'s `CiviCRM_Command::install` because these have conflicts. I'll try to reproduce those changes as a separate/smaller commit.
This reproduces some of the cleanups from 921af8e - specifically, the parts dealing with the method `CiviCRM_Command::install()`
|
I pushed up a patch which gets the 4.6.x upgrade-test to pass (1bdb8e9). I spent some time running upgrades in different permutations (eg wrt to web-vs-cli as medium; wrt starting version; wrt ending version). With 1bdb8e9, it seems to be as good as the status quo -- ie
I haven't tracked where the issue with upgrading in the web ui originated -- but I can say these upgrades looked OK: 4.6=>5.13; 4.6=>5.27; 4.6=>5.39. |
|
@totten Thank you for reviewing this. I'll do a new |
|
I've done another review and Merging. |
|
Yay! Thanks @kcristiano |
|
For end users, what impact does this change have? Does this mean we'll be able to upgrade the CiviCRM plugin via the normal plugin update feature of WordPress? |
(This is a rebased version of @christianwach's #260. I've simply copied/pasted his original description. At the bottom, I'll add some comments about changes/conflict-resolution.)
Overview
This PR should solve a couple of issues on Lab:
It replaces #205 for the above issues.
It also streamlines the plugin load procedure(s):
anonymous_userrole and default capabilities on plugin activation.wp civicrm installnow setswpLoadPhpand creates the Base Page.It should be noted that there is still work to be done when CiviCRM is configured in "Multi-Domain" mode. The procedures to set up new Domains are more complex than CiviCRM in "WordPress Multisite with multiple separate databases" mode. The Base Page, for example, cannot be identified until the new Domain has been properly set up - because the new CiviCRM Domain reads the "root" Domain's settings until that point.
Having said that, this PR improves the experience for most developers most of the time and should help future progress on streamlining "Multi-Domain" mode.
Comments (Rebase/Conflict-Resolution)
There were two PRs going through contemporaneous review, #264 (which just changed the
wp civicrm install) and #260 (which did code-cleanups and functional-updates across many files+functions... includingwp civicrm install). Most files/functions/changes from #260 appear to merge cleanly with #264 - except for very harry conflicts aroundwp civicrm install.So to make this PR, I did the following:
master(which includes (dev/core#1615) wp-cli - Perform CLI installations using Civi\Setup #264).wp civicrm install.wp civicrm install, read and manually reproduce the prose cleanups (comments/messages; 3ad0227).But there is one notable section that I did not reproduce:
r-runningwp civicrm install, I followed the same test procedure that I used in (dev/core#1615) wp-cli - Perform CLI installations using Civi\Setup #264, and I don't see any obvious problems. ThewpLoadPhpsetting appears reasonable in my environment: