Create base page on every site on which CiviCRM is activated #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins re test this please |
1 similar comment
|
Jenkins re test this please |
|
Please hold off on this one until I double check that it does what it's supposed to do! |
5fc86f5 to
9f62320
Compare
|
Okay, so it looks like I'll have to do another PR to make the entire plugin conform to the CiviCRM coding standards before any new PRs pass the dreaded Jenkins tests. |
|
jenkins test this please |
9f62320 to
e13fed3
Compare
|
jenkins test this please |
|
@kcristiano Well, I'm baffled. Apparently "All checks have failed" - yet when I look at the details, I see "Checkstyle: 0 warnings from one analysis." |
|
This is beyond me. I agree it's baffling. |
|
Jenkins hates me :) |
|
Jenkins re test this please |
1 similar comment
|
Jenkins re test this please |
|
Closed in favour of #260 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Solves this issue on Lab.
Before
The base page is only created on main site in WordPress Multisite.
After
The base page created on every site on which CiviCRM is activated in WordPress Multisite.
Technical Details
This PR also introduces the
civicrm_basepage_main_site_onlyfilter which allow plugins to enable /restore the legacy "switch to the main site" behaviour.