dev/core#2558 Insert blank MYSQLTIMESTAMP fields as NULL rather than 0 #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Propose extending the behaviour for date fields to timestamp fields also. This was hinted at in the comment but maybe there was a reason not to? Fixes https://lab.civicrm.org/dev/core/-/issues/2558 for me at any rate...
|
Can one of the admins verify this patch? |
|
(Standard links)
|
|
Cross-referencing: civicrm/civicrm-core#20113 Jenkins test this please (I can't remember if tests run on civicrm-packages) |
|
Jenkins add to whitelist ? |
|
@demeritcowboy do you want to try that last command again pls |
|
Jenkins add to whitelist ? |
|
tests failed - wonder why - definitely relates |
|
@eileenmcnaughton these are potentially flakey tests going to run it again just to be sure |
|
Jenkins re test this please |
|
Looks like test fails were the second barrier issue rather than this PR |
This was referenced Jul 15, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends the behaviour for date fields to timestamp fields also. This was hinted at in the comment but maybe there was a reason not to?
Seems to fix https://lab.civicrm.org/dev/core/-/issues/2558 for me, but is way out of my comfort zone!