[NFC/Unit test] - Failing test demonstrating blank timestamp updates

[demeritcowboy]

Overview

This will fail at the moment.

In civicrm/civicrm-packages#319 insert() was patched to also look for timestamp db fields when inserting a blank date in a field that allows nulls. But update() was not also patched so it has the same problem with timestamp types.

Before

DB Error: unknown error
Incorrect datetime value: '0' for column whatever at row 1

After

After civicrm/civicrm-packages#326, stores null in the db

Technical Details

It only fails if sql_mode has NO_ZERO_DATE.

Comments

#20476

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Test fail expected

[seamuslee001]

CRM_Core_DAOTest::testUpdateTimestampWithBlankDate
Exception: PEAR_Exception: "DB Error: unknown error"
 * ERROR TYPE: DB_Error
 * ERROR CODE: -1
 * ERROR MESSAGE: DB Error: unknown error
 * ERROR MODE: 16
 * ERROR USERINFO: UPDATE  `civicrm_cache`  SET `group_name` = 'mytest' , `path` = 'mypath' , `data` = 'some updated data' , `created_date` = 20210717231255 , `expired_date` = 0   WHERE (  `civicrm_cache`.`id` = 487 )   [nativecode=1292 ** Incorrect datetime value: '0' for column 'expired_date' at row 1]
 * ERROR DEBUGINFO: UPDATE  `civicrm_cache`  SET `group_name` = 'mytest' , `path` = 'mypath' , `data` = 'some updated data' , `created_date` = 20210717231255 , `expired_date` = 0   WHERE (  `civicrm_cache`.`id` = 487 )   [nativecode=1292 ** Incorrect datetime value: '0' for column 'expired_date' at row 1]

[seamuslee001]

now that civicrm/civicrm-packages#326 has been merged, Jenkins retest this please

[demeritcowboy]

Thanks @seamuslee001