Bug fix in civicrm.module

[albionbrown]

Replaced $this with $edit in civicrm_form_data() when not in object context.
Ignore the README I made

[civicrm-builder]

Can one of the admins verify this patch?

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[MegaphoneJon]

Many thanks for the contribution Josh! Are you able to resubmit (perhaps with a forced rebase) without the README so it's mergeable? You can do it now or after review takes place. If you have questions on how to do it, feel free to ask here, or in the ~dev-newcomers channel on https://chat.civicrm.org. Thanks, and welcome!

[albionbrown]

Hi Jon! I forgot to reply to you yesterday, check the latest commit I think it's done now (never done a rebase, but I think it's right!). Josh

…

On Thu, 4 Oct 2018 at 15:05, Jon ***@***.***> wrote: Many thanks for the contribution Josh! Are you able to resubmit (perhaps with a forced rebase) without the README so it's mergeable? You can do it now or after review takes place. If you have questions on how to do it, feel free to ask here, or in the ~dev-newcomers channel on https://chat.civicrm.org. Thanks, and welcome! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#544 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGCdGcgAS1k2IehRsplW4E3vhYTyQ1rDks5uhhWngaJpZM4XH4HN> .

[MegaphoneJon]

This isn't a rebase, but that's OK - the committer can also deal with it on their end.

For whatever reason it's a little harder to get folks who know this repo to review patches compared to the "civicrm-core" repo, and I'm unfortunately not really qualified here. I'll work on finding someone. Thanks again for taking the time.

[jackrabbithanna]

How did the problem manifest before this patch? Is there a process that we can follow to replicate the issue and confirm the fix?

[jackrabbithanna]

This is a duplicate of #541

[albionbrown]

Oh sorry I forgot to note how to reproduce!

1. Log into a Drupal user who can administer CiviCRM and Drupal users
2. Find a contact in Civi whose account is not 'linked' to the Drupal account (The user's account has never been logged into and therefore has no record in civicrm_uf_match table to map Civi ID to Drupal User ID)
3. Go to that contact's associated Drupal user page
4. Click on 'Edit'
5. Finally click on 'User Profile'

[petednz]

i am seeing this same issue on some contacts where there is a uf_match - and where the Name and Address profile on the /user page does show the civi data - but clicking 'edit Name and Address' throws the error. noting this was a WP site that we moved to Drupal, and cleared out all unwanted uf_match rows and fixed up the remaining ones to work. we are seeing this error on newly created users though as well

[mlutfy]

@petednz Can you apply the patch and confirm whether it fixes the issue?

I would still recommend merging #541 instead, because the commit log will be cleaner.

[eileenmcnaughton]

#541 merged - closing this as it seems superceded