Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.1 incompatibility error fix for -> Error: Using $this when not in object context in civicrm_form_data() #541

Merged
merged 1 commit into from
Jan 7, 2019

Conversation

tmannell
Copy link

I was getting this error when attempting to edit civi profiles exposed to drupal user profiles.

Error: Using $this when not in object context in civicrm_form_data() (line 590 of sites/all/modules/civicrm/drupal/civicrm.module).

Changing the $this to the available $edit var, which appears to contain the form, seemed to solve the problem.

@civicrm-builder
Copy link

Can one of the admins verify this patch?

@civibot
Copy link

civibot bot commented Aug 31, 2018

(Standard links)

Copy link
Contributor

@jitendrapurohit jitendrapurohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to replicate this on one of our sites and this PR seems to have fixed it for us. Confirming that it is a good/correct change and should be merged 👍

@eileenmcnaughton
Copy link
Contributor

merging per @jitendrapurohit review - looks like it was checked a while back but no-one spotted that

@eileenmcnaughton eileenmcnaughton merged commit 5be627f into civicrm:7.x-master Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants