fix so the correct paths are pulled for this instance site #271
Conversation
The old code defaulted to sites/default for $conf. This new code was copied from other modules in drupal 7.36 so the url.php redirect now works.
|
It looks like this is addressing the same issue as #168 I don't feel qualified to say which approach is better. |
|
The code in #168 never went into production on our end so I can't really vouch for it. FWIW it seems both ways seem to be a bit hacky, there should be a more drupalish way. |
|
Heh @senner as Release Manager this month, I'm trying to recruit people to help pare down the backlog of almost 100 PRs, some going back to last summer. I'm wondering if you would be able to help QA another PR if I got someone to QA this PR? |
|
@herbdool would you be interested in reviewing this patch? |
|
@JoeMurray sure, I can QA this |
|
@herbdool Great!! |
|
@senner wondering how I can recreate the issue and also best test the patch. This requires sending out CiviMail? The other competing patch suggests it can also be related to finding Civi if it's an install profile, which I'll also try. |
|
@senner wondering if you can provide some more info on what this patch is fixing. I'm not familiar with url.php redirects and if it was broken. |
The old code defaulted to sites/default for $conf. This new code was copied from other modules in drupal 7.36 so the url.php redirect now works.