CRM-19836 Enable activity create from replies to CiviMail. #9655
Conversation
| * @param array $params | ||
| */ | ||
| function _civicrm_api3_job_fetch_bounces_spec(&$params) { | ||
| $params['is_create_activities'] = array( |
There was a problem hiding this comment.
I like the grammar of "is create activities" but what about "can I haz activities?"
There was a problem hiding this comment.
no you may not! but if you look at the line below this comment, that is why I'm sure the var will always be set.
I'll fix the data block
CRM/Utils/Mail/EmailProcessor.php
Outdated
| @@ -48,14 +48,14 @@ class CRM_Utils_Mail_EmailProcessor { | |||
| * Always returns true (for the api). at a later stage we should | |||
| * fix this to return true on success / false on failure etc. | |||
| */ | |||
| public static function processBounces() { | |||
| public static function processBounces($is_create_activities) { | |||
There was a problem hiding this comment.
this variable needs to go in the docblock
api/v3/Job.php
Outdated
| @@ -358,7 +358,7 @@ function civicrm_api3_job_fetch_bounces($params) { | |||
| if (!$lock->isAcquired()) { | |||
| return civicrm_api3_create_error('Could not acquire lock, another EmailProcessor process is running'); | |||
| } | |||
| if (!CRM_Utils_Mail_EmailProcessor::processBounces()) { | |||
| if (!CRM_Utils_Mail_EmailProcessor::processBounces($params['is_create_activities'])) { | |||
There was a problem hiding this comment.
Are you sure this array key will always be set?
This relies on a parameter being added to the api call:
civicrm_api3('Job', 'fetch_bounces', array('is_create_activities' => TRUE));
6d2dde1 to
3ff238a
Compare
|
@colemanw I fixed the data block. I did a bit of clean up on the fantasy return value. processBounces is only called from the api, which handles the possibility a function that never returns false might someday feel like it. I put it out of it's misery |
|
I think the |
CRM-19836 Enable activity create from replies to CiviMail.
This relies on a parameter being added to the api call:
civicrm_api3('Job', 'fetch_bounces', array('is_create_activities' => TRUE));