CRM-21054 - Fix is_create_activities param for fetch_activities job #10846
Conversation
api/v3/Job.php
Outdated
| */ | ||
| function _civicrm_api3_job_fetch_activities_spec(&$params) { | ||
| $params['is_create_activities'] = array( | ||
| 'api.default' => 0, |
There was a problem hiding this comment.
@eileenmcnaughton should this value be 1 ?
There was a problem hiding this comment.
Yes - I think you are right! Will fix
There was a problem hiding this comment.
No, just thinking - I think it should not be a param but rather be always set in the _fetch_activities function - since there is no point calling that fn without creating activities
|
@jitendrapurohit ie I think this line CRM_Utils_Mail_EmailProcessor::processActivities($params['is_create_activities']); should likely be CRM_Utils_Mail_EmailProcessor::processActivities(TRUE); |
|
agree with the change and updated the PR. Thanks @eileenmcnaughton Update: Just modified the uninitialized variable to |
e4e813d to
afc2a15
Compare
|
Ok - I grepped & I agree that this is only called from that function so I'm merging |
Overview
Fixes is_create_activities param for fetch_activities
Before
Process Activities job execution results into notice error.
After
Job executes correctly without errors.
Technical Details
is_create_activitiesparam was introduced in #9655, but it missed the initialization of param inprocessActivities()function. This PR adds those params with specs as done for bounces.is_create_activitiesparam not defined for fetch_activities job