Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-18147 - Advanced filtering on email or email_id does not work for the Contact API #8179

Merged
merged 2 commits into from
Jun 22, 2016

Conversation

monishdeb
Copy link
Member

This patch added the missing fix needed for email attribute when used for advance filtering in Contact API. Missing because this was not handled when improvement was made in early 4.7 release to support advance filtering in API Get.


@eileenmcnaughton
Copy link
Contributor

I'm not too clear about the rationale for this - ie. is it an extra feature or in someway a bug fix.

however, I wouldn't want to see it merged without the magic unit test....

@monishdeb
Copy link
Member Author

Its a bug and miss in recent improvements done to support advance filtering for api.get and Search builder for al entites in 4.7. I have updated the PR which include the api test. In addition the PR fixes -

  1. Earlier civicrm_api3('email', 'create', array('is_primary' => 0, 'email' => email@address, 'contact_id' => id)) always create primary email address as eventually the is_primary attribute got updated to 1
  2. Support email_id attribute w/o advance filters

@monishdeb
Copy link
Member Author

Jenkin test this please

@monishdeb monishdeb force-pushed the CRM-18147 branch 3 times, most recently from c3225f7 to 6287104 Compare April 22, 2016 12:43
@monishdeb
Copy link
Member Author

Jenkin, restest this please

@jitendrapurohit
Copy link
Contributor

checked this PR, works fine. Also updated the changes to fix test failing on Jenkins.

@monishdeb monishdeb merged commit 8390f84 into civicrm:master Jun 22, 2016
@monishdeb monishdeb deleted the CRM-18147 branch June 22, 2016 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants