-
-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRM-18267 upgrade php-font-lib #8165
Conversation
Updated php-font-lib package version to latest 0.4 release.
Can one of the admins verify this patch? |
test this please |
Changed the source URLs and commit references, now they refer to the latest update.
ok to test |
Hi Eileen, I just tracked this on jenkins, there is a checkstyle error (No report files were found). I'm not sure what exactly could have caused this. Could you please help me to get over this one ? Thanks |
let's re-run the test in case it was unrelated! |
test this please |
Hi again, Its showing the same, so any problems in my commits then ? |
Why is |
The testbot is reporting:
Perhaps the composer update should be re-run from a clean copy of master. |
So I need to update |
that sounds about right - there should be a change to both composer.json & composer.lock & yeah, it's good practice to do a git pull --rebase origin master before reworking a patch |
Hi, sorry I have been very busy with my major exams, I received Tim's email and I decided to get this one done. I did rebasing and made changes to |
Submitted a new PR : #8335 |
Updated php-font-lib package version to latest 0.4 release.