CRM-16619 Add financial type code #7759
Conversation
|
Can one of the admins verify this patch? |
022d0c2 to
0716ca8
Compare
|
test this please |
|
jenkins, ok to test |
0716ca8 to
a852e75
Compare
|
I just pushed an updated commit due to linting errors. Sorry about that. |
|
Thank you, Barnaby, for the quick update! FWIW, the new error is a common false-negative. ( https://forum.civicrm.org/index.php?topic=36964.0 ) Since I don't know as much about the financial subsystem, maybe @JoeMurray or @eileenmcnaughton could assess this one? |
| <type>varchar</type> | ||
| <length>255</length> | ||
| <comment>Optional value for mapping financial types to accounting system categories (QuickBooks Classes for example).</comment> | ||
| <add>4.7</add> |
There was a problem hiding this comment.
This would need to be for 4.8.
|
@barnabycourt I'm wondering if this might be better packaged as an extension, because I'm not sure all use cases for QB classes would work this way. Could we perhaps have a call to discuss your requirements and how we could meet them? I'm available as JosephPMurray on Skype, and at 416.466.1281 (Eastern Time) by phone. As I understand classes, they are designed to provide a different way of categorizing revenue and expenses and other bookkeeping entries than according to the Chart of Accounts. This allows them to facilitate management accounting rather than just the financial accounting, for example. However, your design here tacks what will be the class onto the Financial Type in CiviCRM, and Financial Types were designed by Andrew Perry to generally have a one-to-one relationship with the financial accounts for revenue, and merely group other needed accounts like related accounts receivable, tax, and so on with that revenue account. Rather than classes cutting across various financial accounts, they will tend to be another property of each of them. While one can imagine implementations that create multiple financial types to allow various combinations of class and financial account, it seems unwieldy and bloat prone. An alternative implementation might associate a class with a CiviCRM campaign's activities, and thus allow calculation of the ROI for it regardless of the financial types of the line items participants purchased and paid for, eg memberships and donations. There was a Google Summer of Code project last year along these lines (though I don't recall how far it went or whether as Europeans they had any interest in QB classes). Anyway, I'm excited you're making good progress on this and would love to talk to you more about this initiative. |
|
@JoeMurray I'd be happy to discuss in more detail by skype or phone. I'm in Eastern Time as well. Would you prefer to chat 9-5 or in the evening? |
|
9-5 works best. I'm in Toronto by the way. Joe Murray, PhD On Wed, Feb 10, 2016 at 10:53 AM, Barnaby Court notifications@github.com
|
Add a financial type code and use that for class support in accounting batch export IIF and csv generation.
a852e75 to
2eddd81
Compare
|
@JoeMurray I'll try you by skype some time tomorrow (Thursday). I think my view of financial types may be a bit skewed as the vendor that is providing the CiviCRM implementation that I use regularly specifically recommended using multiple financial types with the same income account for the purpose of segregating funds. More generally though, campaign activities make a lot of sense for classes that cross-cut financial types or accounts. Would a precedence order make sense? Use a class from the campaign (if the contribution is part of a campaign and the campaign has specified a class), then fall back to the financial type if one was not set by the campaign? Supporting both would be good as there are times where contributions may need a class applied even though they were not raised as part of a particular campaign. That way users of CiviCRM would have flexibility depending on how they are using the software. |
|
@JoeMurray @eileenmcnaughton If you have format or location that you would prefer the doc be hosted instead of google just let me know. |
|
I'm withdrawing this PR per discussions with @JoeMurray |
|
Can one of the admins verify this patch? |
Add a financial type code attribute to financial types.
When working with accounting batches use this attribute
to specify the quickbooks class for IIF generation.
Also add the attribute to the csv generation.