Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standalone: fix failing E2E test due to getting resource base URL #28475

Merged

Conversation

artfulrobot
Copy link
Contributor

@artfulrobot artfulrobot commented Dec 4, 2023

Fixes E2E\Core\PathUrlTest::testPaths_getUrl

Before

It may be right to enable this test, but it is failing :

1) E2E\Core\PathUrlTest::testPaths_getUrl                                                                                                             
Failed asserting that '' matches PCRE pattern ";https://civicrm.org/licensing;".                                                                      
                                                                                                                                                      
/buildkit/civicrm-buildkit/build/so2/web/core/tests/phpunit/E2E/Core/PathUrlTest.php:168                                                              
/buildkit/civicrm-buildkit/build/so2/web/core/tests/phpunit/E2E/Core/PathUrlTest.php:33                                                               
/buildkit/civicrm-buildkit/extern/phpunit9/phpunit9.phar:2307                                                                                         

On my buildkit, it's getting: http://so2.localhost:8100/js/Common.js but it should be fetching
http://so2.localhost:8100/core/js/Common.js

Despite the Resource URL page saying:

CiviCRM Resource URL http://so2.localhost:8100/core

After

Tests pass.

@ufundo

Copy link

civibot bot commented Dec 4, 2023

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Dec 4, 2023
@artfulrobot artfulrobot force-pushed the artfulrobot-testPaths_getUrl-fix branch 2 times, most recently from 26b4657 to 9486f03 Compare December 5, 2023 12:24
@artfulrobot
Copy link
Contributor Author

ok I've implemented @ufundo's suggestion. I wrapped the constant in the addtrailingslashes, just in case...

Fixes E2E\Core\PathUrlTest::testPaths_getUrl
@artfulrobot artfulrobot force-pushed the artfulrobot-testPaths_getUrl-fix branch from 9486f03 to 5ae4087 Compare December 5, 2023 12:27
@totten totten merged commit cfb4ff7 into civicrm:master Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants