Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standalone PathUrlTest #28419

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Conversation

ufundo
Copy link
Contributor

@ufundo ufundo commented Dec 2, 2023

Overview

Include Standalone in PathUrlTest::testUrl . It uses Drupal-like url paths.

Fixes a typo and updates pat to pattern for clarity

Before

Test fails for Standalone because no CIVICRM_UF match.

After

Test will still fail because of anonymous userID issue (#28414) But hopefully after that is fixed it will pass should pass now this is merged #28443.

No more PAT testing though

Copy link

civibot bot commented Dec 2, 2023

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Dec 2, 2023
@pfigel
Copy link
Contributor

pfigel commented Dec 3, 2023

test this please

@artfulrobot
Copy link
Contributor

I agree with adding standalone in here, but urlPats was short for urlPatterns, not a mis-spelling of urlPaths...

@ufundo ufundo force-pushed the standalone-url-test branch from 241d8f2 to ecd7c21 Compare December 4, 2023 17:12
@ufundo
Copy link
Contributor Author

ufundo commented Dec 4, 2023

Updated pat => pattern :)

@artfulrobot
Copy link
Contributor

Confirmed this works and test passes.

@artfulrobot artfulrobot merged commit 9e61e7e into civicrm:master Dec 4, 2023
@artfulrobot
Copy link
Contributor

Related (slightly): #28475

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants