Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF][PHP8.2] Avoid dynamic properties in api_v3_ContactTypeTest #25342

Merged

Conversation

braders
Copy link
Contributor

@braders braders commented Jan 13, 2023

Overview

Avoid dynamic properties in api_v3_ContactTypeTest

Before

Several properties set and retreived dynamically, which is deprecated in PHP 8.2. See https://lab.civicrm.org/dev/core/-/issues/3833 for context.

After

Correctly declare properties for api_v3_ContactTypeTest

Comments

_apiversion seems a bit pointlessly declared on line 17, as it's also declared in the parent, but I wasn't sure if there was a reason I'm missing so I've left it.

I've also tidied up some variables which were being set but not used.

@civibot
Copy link

civibot bot commented Jan 13, 2023

(Standard links)

@civibot civibot bot added the master label Jan 13, 2023
@seamuslee001 seamuslee001 merged commit 1bfd2e8 into civicrm:master Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants