[REF][PHP8.2] Avoid dynamic properties in api_v3_ContactTypeTest #25342
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Avoid dynamic properties in api_v3_ContactTypeTest
Before
Several properties set and retreived dynamically, which is deprecated in PHP 8.2. See https://lab.civicrm.org/dev/core/-/issues/3833 for context.
After
Correctly declare properties for
api_v3_ContactTypeTest
Comments
_apiversion
seems a bit pointlessly declared on line 17, as it's also declared in the parent, but I wasn't sure if there was a reason I'm missing so I've left it.I've also tidied up some variables which were being set but not used.