Merge pull request #25342 from braders/dynamic-params-contact-type-test

[REF][PHP8.2] Avoid dynamic properties in api_v3_ContactTypeTest
civicrm · Jan 14, 2023 · 1bfd2e8 · 1bfd2e8
2 parents 4c0d9a7 + e265090
commit 1bfd2e8
Showing 1 changed file with 26 additions and 11 deletions.
diff --git a/tests/phpunit/api/v3/ContactTypeTest.php b/tests/phpunit/api/v3/ContactTypeTest.php
@@ -16,6 +16,21 @@
 class api_v3_ContactTypeTest extends CiviUnitTestCase {
   protected $_apiversion;
 
+  /**
+   * @var string
+   */
+  protected $subTypeIndividual;
+
+  /**
+   * @var string
+   */
+  protected $subTypeOrganization;
+
+  /**
+   * @var string
+   */
+  protected $subTypeHousehold;
+
   public function setUp(): void {
     parent::setUp();
     $this->useTransaction(TRUE);
@@ -26,7 +41,7 @@ public function setUp(): void {
       'parent_id' => 1,
       'is_active' => 1,
     ];
-    $result = CRM_Contact_BAO_ContactType::add($params);
+    CRM_Contact_BAO_ContactType::add($params);
     $this->subTypeIndividual = $params['name'];
 
     $params = [
@@ -36,7 +51,7 @@ public function setUp(): void {
       'parent_id' => 3,
       'is_active' => 1,
     ];
-    $result = CRM_Contact_BAO_ContactType::add($params);
+    CRM_Contact_BAO_ContactType::add($params);
     $this->subTypeOrganization = $params['name'];
 
     $params = [
@@ -46,7 +61,7 @@ public function setUp(): void {
       'parent_id' => 2,
       'is_active' => 1,
     ];
-    $result = CRM_Contact_BAO_ContactType::add($params);
+    CRM_Contact_BAO_ContactType::add($params);
     $this->subTypeHousehold = $params['name'];
   }
 
@@ -111,15 +126,15 @@ public function testContactAddInvalidData($version) {
       'contact_type' => 'Individual',
       'contact_sub_type' => $this->subTypeHousehold,
     ];
-    $contact = $this->callAPIFailure('contact', 'create', $contactParams);
+    $this->callAPIFailure('contact', 'create', $contactParams);
 
     // check for Type:Organization Subtype:sub_individual
     $contactParams = [
       'organization_name' => 'Compumentor',
       'contact_type' => 'Organization',
       'contact_sub_type' => $this->subTypeIndividual,
     ];
-    $contact = $this->callAPIFailure('contact', 'create', $contactParams);
+    $this->callAPIFailure('contact', 'create', $contactParams);
   }
 
   /**
@@ -214,7 +229,7 @@ public function testContactUpdateNoSubtypeInvalid($version) {
       'contact_type' => 'Individual',
       'contact_sub_type' => $this->subTypeHousehold,
     ];
-    $updateContact = $this->callAPIFailure('contact', 'create', $updateParams);
+    $this->callAPIFailure('contact', 'create', $updateParams);
     $params = [
       'contact_id' => $contact['id'],
     ];
@@ -233,7 +248,7 @@ public function testContactUpdateNoSubtypeInvalid($version) {
       'contact_type' => 'Organization',
       'contact_sub_type' => $this->subTypeIndividual,
     ];
-    $updateContact = $this->callAPIFailure('contact', 'create', $updateParams);
+    $this->callAPIFailure('contact', 'create', $updateParams);
     $params = [
       'contact_id' => $contact['id'],
     ];
@@ -256,7 +271,7 @@ public function testContactUpdateSubtypeValid($version) {
       'parent_id' => 1,
       'is_active' => 1,
     ];
-    $getSubtype = CRM_Contact_BAO_ContactType::add($params);
+    CRM_Contact_BAO_ContactType::add($params);
     $subtype = $params['name'];
 
     // check for Type:Individual subype:sub_individual
@@ -299,7 +314,7 @@ public function testContactUpdateSubtypeValid($version) {
       'parent_id' => 3,
       'is_active' => 1,
     ];
-    $getSubtype = CRM_Contact_BAO_ContactType::add($params);
+    CRM_Contact_BAO_ContactType::add($params);
     $subtype = $params['name'];
 
     // check for Type:Organization subype:sub_organization
@@ -357,7 +372,7 @@ public function testContactUpdateSubtypeInvalid($version) {
       'contact_type' => 'Individual',
       'contact_sub_type' => $this->subTypeHousehold,
     ];
-    $updateContact = $this->callAPIFailure('contact', 'create', $updateParams);
+    $this->callAPIFailure('contact', 'create', $updateParams);
     $params = [
       'contact_id' => $contact['id'],
     ];
@@ -376,7 +391,7 @@ public function testContactUpdateSubtypeInvalid($version) {
       'contact_id' => $contact['id'],
       'contact_sub_type' => $this->subTypeIndividual,
     ];
-    $updateContact = $this->callAPIFailure('contact', 'create', $updateParams);
+    $this->callAPIFailure('contact', 'create', $updateParams);
     $params = [
       'contact_id' => $contact['id'],
     ];