Fix #4049 Nested tags not showing under some circumstances #25218

[gellweiler]

I accidentally closed my old PR: #25218. So here is a new PR with a test class.

This commit fixes #4049.

Bug description: When nested tags were not created in the same order as they are nested, they are not shown in the add tag to contact dialog.

See: https://lab.civicrm.org/dev/core/-/issues/4049

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@gellweiler thank you for the test & the clear instructions - I was able to replicate the bug & see that this fixes it.

I realised working through the issue that this is a regression - and hence our practice is to target the rc with the patch .

Since the rc is being cut tomorrow to the new 5.57.0 release I figured I should create a new PR porting this rather than ask you to rebase against the 5.57 branch - #25272

Can you please do another PR against 5.57 branch adding yourself to the contributor-key.yml file https://github.com/civicrm/civicrm-core/blob/master/contributor-key.yml so we can include you in the release notes

[gellweiler]

@eileenmcnaughton will do

[gellweiler]

@eileenmcnaughton #25273

[eileenmcnaughton]

@gellweiler great!

[eileenmcnaughton]

@gellweiler I'm closing this now as I've up-merged from 5.57 here #25274