Fix #4049 Nested tags not showing under some circumstances

[gellweiler]

This commit fixes #4049.

Bug description: When nested tags were not created in the same order as they are nested, they are not shown in the add tag to contact dialog.

See: https://lab.civicrm.org/dev/core/-/issues/4049

[civicrm-builder]

Can one of the admins verify this patch?

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

jenkins add to whitelist

[gellweiler]

Fixed the style issue. Perhaps we should also unit test the tag tree algorithm to prevent this or a similar bug from reemerging. What are your thoughts on that?

[eileenmcnaughton]

@gellweiler I'm always in favour of unit tests - looking I can't see any existing tests on that function - in fact the class CRM_Core_BAO_TagTest doesn't even exist! - are you comfortable creating a test?

[gellweiler]

Ok I will write a test this week. I have no experience with mocking the db in civicrm but I guess I can just look at other tests as a reference. I tend to write more Java code these days than PHP so I'm not that familiar with the typical test frameworks in PHP but copy and paste I guess will get the me there.

[gellweiler]

@eileenmcnaughton I've added a test by ammending my commit and force pushing to the branch. Apparently that closed the PR. Can you open it again? I use mostly gitlab these days and I'm a bit confused of the behavior of GitHub in this instance.

[gellweiler]

@eileenmcnaughton Ok so what happend is I accidentially removed my commit from my fork and did a force push. Apprently that closed the PR. I had to open a new PR. Sorry about that: #25254