Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post code-divide tidy-up #25194

Merged
merged 1 commit into from
Dec 18, 2022
Merged

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Dec 16, 2022

Overview

Post code-divide tidy-up

Follow up to #25184

Before

Previously shared code still accepts historical parameters

    $priceSetId = CRM_Price_BAO_PriceSet::getFor('civicrm_contribution_page', $this->_id);
      $this->initSet($this, 'civicrm_contribution_page', FALSE, $priceSetId);

After

Cruft from previous sharing gone

Technical Details

Comments

@civibot
Copy link

civibot bot commented Dec 16, 2022

(Standard links)

@civibot civibot bot added the master label Dec 16, 2022
eileenmcnaughton added a commit to eileenmcnaughton/civicrm-core that referenced this pull request Dec 16, 2022
Per civicrm#25194
But the other function split out from

civicrm#25184
@demeritcowboy demeritcowboy merged commit 3e71115 into civicrm:master Dec 18, 2022
@eileenmcnaughton eileenmcnaughton deleted the build_divide branch December 18, 2022 02:25
eileenmcnaughton added a commit to eileenmcnaughton/civicrm-core that referenced this pull request Jan 20, 2023
Per civicrm#25194
But the other function split out from

civicrm#25184
eileenmcnaughton added a commit to eileenmcnaughton/civicrm-core that referenced this pull request Feb 6, 2023
Per civicrm#25194
But the other function split out from

civicrm#25184
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants