Divide & conquer, initSet no longer shared as much code is not
#25184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
5b1a1c1 to
045915e
Compare
|
@demeritcowboy are you able to merge this - it's just copying the function to 2 places - but I can rip it mostly out of one - I'm trying to work through the assumption that priceSet is ALWAYS set unless it is not monetary - which stacks up in my UI testing - & from there to figure out what |
|
Thanks @demeritcowboy |
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Dec 16, 2022
Follow up to civicrm#25184
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Dec 16, 2022
Per civicrm#25194 But the other function split out from civicrm#25184
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Dec 16, 2022
Follow up to civicrm#25184
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Jan 20, 2023
Per civicrm#25194 But the other function split out from civicrm#25184
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Feb 6, 2023
Per civicrm#25194 But the other function split out from civicrm#25184
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Divide & conquer,
initSetno longer shared as much code is notBefore
BAO_PriceSet::initSetcalled by 2 functions, much of the code is specific to the different calling functionsAfter
Function copied to it's callers & deprecated
Technical Details
Follow up tidy up can strip out the code that is not relevant to each place
Comments