dev/core#1532 - Upgrade message about old civicase activity revisions

[demeritcowboy]

Overview

Followup to #25113

Before

Activity revisions still filterable in api4/searchkit/etc.

After

No longer selectable to be filterable in UI.

Technical Details

I also ran into https://lab.civicrm.org/extensions/caseactivityrevisionmigrator/-/issues/4 where the ON DELETE CASCADE is dangerous, so included that here.

Comments

I also updated the referenced lab snippet.

Given the timing I may need to rebase/move to beta1.

[civibot]

No issue was found matching the number given in the pull request title. Please check the issue number.

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

jenkins retest this please

[demeritcowboy]

I had added IF EXISTS to the sql which works on mariadb but seems it doesn't on mysql. But I only added that because I had been playing around. In real life it should always exist, even if you rerun the upgrade step.

[demeritcowboy]

jenkins what are you talking about

api\v4\SearchDisplay\SearchRunTest::testContributionCurrency
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'GBP'
+'JPY'

/home/jenkins/bknix-dfl/build/core-25119-3qtv6/web/sites/all/modules/civicrm/ext/search_kit/tests/phpunit/api/v4/SearchDisplay/SearchRunTest.php:1414

retest this please

[demeritcowboy]

I think this PR is cursed.

E2E\Core\AssetBuilderTest::testInvalid
GuzzleHttp\Exception\ConnectException: cURL error 28: Operation timed out after 2001 milliseconds with 0 bytes received 

jenkins retest this please

[colemanw]

This looks good.

[demeritcowboy]

OMG jenkins retest this please

[demeritcowboy]

Thanks @colemanw
Deprecation warning: "Thanks" is deprecated. Use "Yeah baby!".

[seamuslee001]

Finally @demeritcowboy