Hide deprecated fields from SearchKit & Afform

[colemanw]

Overview

Hides any fields marked @deprecated from the SK & Afform UI. Follow-up to #25112.

Before

Now you see them.

After

Now you don't.

Technical Details

This builds on #24248 and #25112 and more recently #25112 by exposing the 'deprecated' attribute to APIv4 getfields and then filtering them out in SK & Afform.

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

@colemanw just hypothetically if someone had created a saved search kit using one of these fields would that mean the search display / Search kit breaks doing this because the field no longer renders in the Admin UI / any UI?

[colemanw]

@seamuslee001 yes, the search will still run, but that field will disappear next time you edit it.

[demeritcowboy]

• This works
• I have mixed feelings about is_current_revision. Not in terms of deprecating it, but in terms of it suddenly disappearing without warning if they have a search using it and edit it, which is more like removal/disabling rather than deprecation. I'd feel more comfortable with that one out for the moment.
• Not a blocker but api4 explorer could benefit from some words or visual clue that the field is deprecated.

[colemanw]

I have mixed feelings about is_current_revision. Not in terms of deprecating it, but in terms of it suddenly disappearing without warning if they have a search using it and edit it, which is more like removal/disabling rather than deprecation. I'd feel more comfortable with that one out for the moment.

OTOH, the longer we leave it in, the more likely someone is to use it. Do you know of anyone already doing so? I was assuming probably not.

[demeritcowboy]

I see your point, and I forgot we already did

civicrm-core/CRM/Upgrade/Incremental/php/FiveFiftyFour.php

Line 28 in 133a8c5

$preUpgradeMessage .= '<p>' . ts('The setting that used to be at <em>Administer &gt; CiviCase &gt; CiviCase Settings</em> for <strong>Enable deprecated Embedded Activity Revisions</strong> is enabled, but is no longer functional.<ul><li>For more information see this <a %1>Lab Snippet</a>.</li></ul>', [1 => 'target="_blank" href="https://lab.civicrm.org/-/snippets/85"']) . '</p>';

which will have caught some of that. It's just what's different about is_current_revision vs phone_id is that nobody who was just using core code will have anything in phone_id, whereas there will be people who have old revisions, with no way to exclude them from reporting except to do one of the things in the lab snippet mentioned by the earlier upgrade message.

So it doesn't block this PR but I'll look at doing an upgrade message for anyone who has an activity with is_current_revision=0, and point them to the snippet. The previous one was just for people with the setting still turned on.