Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix accidental revert of import batch size #24773

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Fix accidental revert of import batch size #24773

merged 1 commit into from
Oct 20, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

port #24772

@eileenmcnaughton
Fix accidental revert of import batch size
cffa05d 
Overview
----------------------------------------
We increased batch size to 50 in 5.52 but appear to have accidentally
re-set it to 5. This was presumably due to code being merged that
patched the code with the older value & hadn't picked up the new

Before
----------------------------------------
Each batch is 5 records

After
----------------------------------------
Each batch is 50 records

Technical Details
----------------------------------------
There seems to be consensus this should be at least 50.
100 is also on the table but I went with Andy's comment
civicrm#24151 (comment)

The issue Andy points out about the 3 second delay between batches seems excessive
and worth digging into. There used to be a 30 second delay in the UI just to
let people really luxuriate in watching our batch screen - not sure
if that is still there?
@civibot
Copy link

civibot bot commented Oct 20, 2022

(Standard links)

@civibot civibot bot added the 5.54 label Oct 20, 2022
@totten totten merged commit 8cfbe42 into civicrm:5.54 Oct 20, 2022
@totten totten deleted the import branch October 20, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
5.54
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @totten