Fix accidental revert of import batch size #24772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overview ---------------------------------------- We increased batch size to 50 in 5.52 but appear to have accidentally re-set it to 5. This was presumably due to code being merged that patched the code with the older value & hadn't picked up the new Before ---------------------------------------- Each batch is 5 records After ---------------------------------------- Each batch is 50 records Technical Details ---------------------------------------- There seems to be consensus this should be at least 50. 100 is also on the table but I went with Andy's comment civicrm#24151 (comment) The issue Andy points out about the 3 second delay between batches seems excessive and worth digging into. There used to be a 30 second delay in the UI just to let people really luxuriate in watching our batch screen - not sure if that is still there?
|
(Standard links)
|
This was referenced Oct 20, 2022
That sounds good. Kick off your shoes, open a bottle of wine, and watch the progress bar. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We increased batch size to 50 in 5.52 but appear to have accidentally re-set it to 5. This was presumably due to code being merged that patched the code with the older value & hadn't picked up the new
Before
Each batch is 5 records
After
Each batch is 50 records
Technical Details
There seems to be consensus this should be at least 50. 100 is also on the table but I went with Andy's comment #24151 (comment)
The issue @andyburnsco points out about the 3 second delay between batches seems excessive and worth digging into. There used to be a 30 second delay in the UI just to let people really luxuriate in watching our batch screen - not sure if that is still there?