-
-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add psr0 to afform extensions #24714
Conversation
(Standard links)
|
@@ -28,6 +28,7 @@ | |||
</civix> | |||
<classloader> | |||
<psr4 prefix="Civi\" path="Civi"/> | |||
<psr0 prefix="CRM_" path="."/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't the path be CRM?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seamuslee001 no - the above was the conclusion reached between @demeritcowboy & @totten & added to Civix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the difference between ""
and "."
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah - that was something that @totten & @demeritcowboy discussed & agreed during the training - I don't know but it is the combined wisdom of 2 very large brains to add the version I added to civix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where I got "." from was this issue where I first tried "" and it didn't work and then I banged on the keyboard until I got the page to load. Isn't that how everyone does civi development?
It could be specific to the class-scanner and the extension and something about what it's looking for that might explain why the ones with "" aren't a problem. Maybe the csvimporter extension does something in a CRM class that others don't.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the training @totten tested with & it worked so the keyboard banging at our end was a success & did not result in head banging
OK. Tests pass and the conversation seems to have reached agreement. |
port #24713 to 5.54