Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add psr0 to afform extensions #24714

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Conversation

eileenmcnaughton
Copy link
Contributor

port #24713 to 5.54

@civibot
Copy link

civibot bot commented Oct 11, 2022

(Standard links)

@civibot civibot bot added the 5.54 label Oct 11, 2022
@@ -28,6 +28,7 @@
</civix>
<classloader>
<psr4 prefix="Civi\" path="Civi"/>
<psr0 prefix="CRM_" path="."/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't the path be CRM?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seamuslee001 no - the above was the conclusion reached between @demeritcowboy & @totten & added to Civix

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between "" and "."?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah - that was something that @totten & @demeritcowboy discussed & agreed during the training - I don't know but it is the combined wisdom of 2 very large brains to add the version I added to civix

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where I got "." from was this issue where I first tried "" and it didn't work and then I banged on the keyboard until I got the page to load. Isn't that how everyone does civi development?

It could be specific to the class-scanner and the extension and something about what it's looking for that might explain why the ones with "" aren't a problem. Maybe the csvimporter extension does something in a CRM class that others don't.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the training @totten tested with & it worked so the keyboard banging at our end was a success & did not result in head banging

@colemanw colemanw merged commit f6baa79 into civicrm:5.54 Oct 11, 2022
@colemanw colemanw deleted the prs554 branch October 11, 2022 14:43
@colemanw
Copy link
Member

OK. Tests pass and the conversation seems to have reached agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants