Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add psr0 to afform extensions #24713

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Add psr0 to afform extensions #24713

merged 1 commit into from
Oct 11, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Add psr0 to afform extensions

Before

Possible to get this obscure fail #24712

After

That one is working again

Technical Details

We added psr0 to civix but core extensions need it added - not all however, only those with CRM classes. I was going to run civix upgrade on all of them but hit a couple of things

  1. I wanted to resolve this first - Add some return hints totten/civix#263 (comment) -(I don't think the comments are blocking)
  2. I hit some errors around mgd version

So I focused on quickly fixing the ones I knew to be problems. Note I did check the line is where civix puts it (below the psr4 line)

Comments

@civibot
Copy link

civibot bot commented Oct 11, 2022

(Standard links)

@civibot civibot bot added the 5.55 label Oct 11, 2022
@colemanw colemanw merged commit c333932 into civicrm:5.55 Oct 11, 2022
@colemanw colemanw deleted the psr0 branch October 11, 2022 14:44
@colemanw
Copy link
Member

OK. Tests pass and the conversation in #24714 seems to have reached agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants