Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify greeting handling, add test #23629

Merged
merged 1 commit into from
May 31, 2022
Merged

Simplify greeting handling, add test #23629

merged 1 commit into from
May 31, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented May 30, 2022 •
edited
Loading

Overview

Simplify greeting handling, add test

Before

Lots of code but no specific test for greeting handling

After

Less code, more tests

Technical Details

Comments

builds on #23623 and #23626

@civibot
Copy link

civibot bot commented May 30, 2022

(Standard links)

@civibot civibot bot added the master label May 30, 2022
@eileenmcnaughton eileenmcnaughton force-pushed the import_greetings branch 4 times, most recently from 0cf561a to f216644 Compare May 30, 2022 04:36
@eileenmcnaughton eileenmcnaughton mentioned this pull request May 30, 2022
Closed
@eileenmcnaughton eileenmcnaughton force-pushed the import_greetings branch 5 times, most recently from 80eb323 to 96cd3f3 Compare May 31, 2022 07:01
@colemanw
Copy link
Member

Less code, more tests. I like it.

@colemanw colemanw merged commit 508c9f8 into civicrm:master May 31, 2022
@eileenmcnaughton eileenmcnaughton deleted the import_greetings branch May 31, 2022 21:28
@eileenmcnaughton
Copy link
Contributor Author

@colemanw #23630 is the next one on top - should I rebase that now - or are you looking at it?

@eileenmcnaughton
Copy link
Contributor Author

looks like they all needed rebasing :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
has-test master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @colemanw