Deprecate crazy BAO handling of preferred_communication_method

[eileenmcnaughton]

Overview

Deprecate crazy BAO handling of preferred_communication_method

Before

Lots of duplicate handling for imploding preferred_communication_method

After

Deprecated in the BAO, duplicate methods removed in the Import

Technical Details

In the context of import this is tested in
testImportFieldsWithVariousOptions

• for the api it is tested via testPseudoFields - although in
  api context it is just a deprecation

Comments

one of the tests was buggy - passing [1,4] needed to fail for the test to pass - even though the checks made it clear that wasn't the expecation. It works now in import

Also - some tests were passing this in - but it's not clear they reflect 'real usage' - if there IS real usage it will cause deprecation notices but it will still work

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

@eileenmcnaughton it looks like this is changing the expected input format from an associative array of boolean checkbox values keyed by id, e.g. [6 => 1, 22 => 0, 31 =>1] to a non-associative array of ids e.g. [6, 31].
Does this change the API contract?

[eileenmcnaughton]

@colemanw no - the api contract already accepted both - it still does - but with a deprecation notice. The tests had to be changed to avoid the notice

[colemanw]

OK.