[Import] Consolidate DataSource.tpl for Custom import

[eileenmcnaughton]

Overview

Consolidate DataSource.tpl for Custom import

Before

After

Technical Details

1. this change Does move the field set chooser below contact type - which is marginally less good - but I think it might make more sense when I figure out how to bring in the contact import into the same tpl.

2. the original displayed an error message if you tried to access the form, absent having any multple record fields. I switched to a statusBounce - but @colemanw I wonder if we could somehow just exclude from the navigation menu?

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@colemanw I'm thinking maybe the statusBounce is enough here - but would be good to get this merged - I'm expecting to have to resolve a conflict with #23456 (whichever is merged first)

[eileenmcnaughton]

@colemanw I'm trying to figure out a sane way to make this form unavailable when there are no multiple custom data sets on the site.

It used to be a message in the middle of the template & then it would fail form validation on submit

I thought a statusBounce would be better - but then it would up in a loop. So here I've tried an access_callback - which works (in that the page doesn't loop but you can't use it due to permission denied) but it doesn't remove it from the navigation menu as I'd hoped it would when disabled. Any ideas? This is the last of the DataSource.tpl files other than the merge with the contact one so getting this merged gets me close to being able to use the same method for all

[eileenmcnaughton]

test this please

[eileenmcnaughton]

Closing this as will re-visit the import - not much movement on this one...