[Import] Consolidate DataSource.tpl - template for first file on activity import #23456
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Consolidate DataSource.tpl - template for first file on activity import
There are no substantive differences between the tpl used for Activity import compared with the one currenly shared by Contribution & Membership import
Before
After
Technical Details
I took a look at the activity DataSource.tpl and aside from minor
markup the only difference between it and the shared markup is
the absense of 'contactType' on the Activity form - so
I added an 'if'
Also - as suggested in the readme - onDuplicate is not used in the Activity import - it's just copy & paste so I removed from php & made it conditional in the tpl
Comments