Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let's see.... #23032

Closed
wants to merge 1 commit into from
Closed

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Mar 25, 2022

Overview

not mergeable until #23017 is but seeing how ci goes
Before

What is the old user-interface or technical-contract (as appropriate)?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.

After

What changed? What is new old user-interface or technical-contract?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.

Technical Details

If the PR involves technical details/changes/considerations which would not be manifest to a casual developer skimming the above sections, please describe the details here.

Comments

Anything else you would like the reviewer to note

@civibot
Copy link

civibot bot commented Mar 25, 2022

(Standard links)

@civibot civibot bot added the master label Mar 25, 2022
@seamuslee001
Copy link
Contributor

at least

not ok 776 - Failure: CRM_Contribute_BAO_ContributionTest::testContributionQuickConfigTwoLineItems
  ---
  message: 'Failure in api call for order create:  Error in call to Payment_create :
    Undefined array key "is_separate_payment"'
  severity: fail
  ...

@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 yeah - thanks - I think the one this builds off #23017 is mergeable though - I have to think more about this

@eileenmcnaughton
Copy link
Contributor Author

Some challenges on this one - gonna try another var in case it is easier...

@eileenmcnaughton eileenmcnaughton deleted the secondy branch March 30, 2022 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants