Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove isset(taxAmount) from membership online receipt #23017

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Remove isset(taxAmount) from membership online receipt

Before

Default template fatals if smarty mode is grumpy

After

does not use isset

Technical Details

isset was added for notices in smarty ...

Comments

@civibot
Copy link

civibot bot commented Mar 23, 2022

(Standard links)

@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 @colemanw one more isset to go

@eileenmcnaughton eileenmcnaughton mentioned this pull request Mar 25, 2022
@eileenmcnaughton
Copy link
Contributor Author

@colemanw @seamuslee001 I just redid the stale regen - can we get this one merged before it goes stale again?

@eileenmcnaughton eileenmcnaughton merged commit eab83b7 into civicrm:master Mar 30, 2022
@eileenmcnaughton eileenmcnaughton deleted the second branch March 30, 2022 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants